-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nuke nix #116
Nuke nix #116
Conversation
Hi and thanks a lot for the PR! I think the whole picture makes sense. A few questions:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, cool. Let's add comments on the bigger things you copy-pasted from nix so we leave a little credit. Then squash all commits into one and I think we're ready for merge.
...assuming all cargo tests still run fine, that is. |
Nuke nix Undo formatting Include raw int in error message Add links to nix src
...and it's in! Assuming you want an alsa 0.9 release with this code in it, are there any other dependencies I should update before I go ahead and release a 0.9? |
Thanks! Nope, I don't believe so, libc has been 0.2 for forever and this crate already uses the latest bitflags, it was only nix that was the issue. |
Released now, enjoy! |
Thanks for the quick turnaround! |
I noticed #114 (comment) when I was looking to see why the 0.8.1 version of this crate is using an older version of nix so figured removing nix would be fine. This crate has constantly been using slightly older versions of nix from other dependencies we use, and when I went to replace the use of nix found that the usage was incredibly minimal.
I only tested on linux and had the same test failures as before this change so don't think I broke anything, but I wasn't sure what the intended support for BSD-like targets is since this crate doesn't seem to state anything about them or have CI for them, but I did add support for them, though I failed to figure out to actually get eg. freebsd to build via cross.