Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spikes object, remove job_kwargs, replace output_folder and code cleanup #47

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

MilagrosMarin
Copy link

@MilagrosMarin MilagrosMarin commented Jul 30, 2024

  • Main purpose of this PR: to fix the following error in the CuratedClustering step: "AttributeError: 'ComputeSpikeLocations' object has no attribute 'spikes'".
    • Solution: spikes object no longer available from ComputeSpikeLocations -> refactor logic following the same solution implemented in this PR in element_array_ephys a month ago.
  • job_kwargs is removed for sparsity calculation following this PR
  • Code cleanup
  • feat: replace output_folder with folder when calling run_sorter following this PR

@MilagrosMarin MilagrosMarin requested a review from ttngu207 July 30, 2024 19:38
@MilagrosMarin MilagrosMarin changed the title fix: spikes object no longer available from ComputeSpikeLocations fix: spikes object, remove job_kwargs, replace output_folder and code cleanup Jul 31, 2024
@ttngu207 ttngu207 merged commit 502c24e into main Jul 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants