Sourcery refactored main branch #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| with open(path) as f: | ||
| queries[path.stem] = f.read() | ||
| queries[path.stem] = Path(path).read_text() |
There was a problem hiding this comment.
Function load_queries refactored with the following changes:
- Simplify basic file reads with
pathlib(path-read)
Comment on lines
-88
to
+95
|
|
||
| r = request_with_retries(self.session.get, self.home_url) | ||
| json_regex = r'<script id="__NEXT_DATA__" type="application\/json">(.+?)</script>' | ||
| json_text = re.search(json_regex, r.text).group(1) | ||
| json_text = re.search(json_regex, r.text)[1] | ||
| next_data = json.loads(json_text) | ||
|
|
||
| self.formkey = next_data["props"]["formkey"] | ||
| self.viewer = next_data["props"]["pageProps"]["payload"]["viewer"] | ||
|
|
There was a problem hiding this comment.
Function Client.get_next_data refactored with the following changes:
- Replace m.group(x) with m[x] for re.Match objects (
use-getitem-for-re-match-groups)
Comment on lines
-101
to
+113
| if not "availableBots" in viewer: | ||
| if "availableBots" not in viewer: | ||
| raise RuntimeError("Invalid token.") | ||
| bot_list = viewer["availableBots"] | ||
|
|
||
| bots = {} | ||
| for bot in bot_list: | ||
| url = f'https://poe.com/_next/data/{self.next_data["buildId"]}/{bot["displayName"].lower()}.json' | ||
| logger.info("Downloading "+url) | ||
| logger.info(f"Downloading {url}") | ||
|
|
||
| r = request_with_retries(self.session.get, url) | ||
|
|
||
| chat_data = r.json()["pageProps"]["payload"]["chatOfBotDisplayName"] | ||
| bots[chat_data["defaultBotObject"]["nickname"]] = chat_data | ||
|
|
There was a problem hiding this comment.
Function Client.get_bots refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan) - Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-136
to
+135
| return f'wss://{self.ws_domain}.tch.{channel["baseHost"]}/up/{channel["boxName"]}/updates'+query | ||
| return f'wss://{self.ws_domain}.tch.{channel["baseHost"]}/up/{channel["boxName"]}/updates{query}' |
There was a problem hiding this comment.
Function Client.get_websocket_url refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-143
to
+148
| if data["data"] == None: | ||
| if data["data"] is None: | ||
| logger.warn(f'{query_name} returned an error: {data["errors"][0]["message"]} | Retrying ({i+1}/20)') | ||
| time.sleep(2) | ||
| continue | ||
|
|
||
| return r.json() | ||
|
|
There was a problem hiding this comment.
Function Client.send_query refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
Comment on lines
-216
to
+215
| #indicate that the response id is tied to the human message id | ||
| elif key != "pending" and value == None and message["state"] != "complete": | ||
| elif key != "pending" and value is None and message["state"] != "complete": |
There was a problem hiding this comment.
Function Client.on_message refactored with the following changes:
- Use x is None rather than x == None (
none-compare)
This removes the following comments ( why? ):
#indicate that the response id is tied to the human message id
Comment on lines
-297
to
+295
| if not type(message_ids) is list: | ||
| if type(message_ids) is not list: |
There was a problem hiding this comment.
Function Client.delete_message refactored with the following changes:
- Simplify logical expression using De Morgan identities (
de-morgan)
Comment on lines
-306
to
+304
| last_messages = self.get_message_history(chatbot, count=50)[::-1] | ||
| while last_messages: | ||
| while last_messages := self.get_message_history(chatbot, count=50)[::-1]: |
There was a problem hiding this comment.
Function Client.purge_conversation refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression) - Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!