[jvm-packages] Supports external memory #11127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbo4958
force-pushed
the
external-memory-jvm
branch
from
c9a074e to
9c50758
Compare
wbo4958
force-pushed
the
external-memory-jvm
branch
from
9c50758 to
20a36f8
Compare
trivialfis
reviewed
Jan 10, 2025
| int nthread) throws XGBoostError { | ||
| this(iter, null, missing, maxBin, nthread); | ||
| int nthread, | ||
| boolean useExternalMemory) throws XGBoostError { |
There was a problem hiding this comment.
Can we have a new structure for external memory instead of reusing the class?
| @@ -391,6 +392,116 @@ class DataIteratorProxy { | |||
| }; | |||
| }; | |||
|
|
|||
| // An iterator proxy for external memory. | |||
| class ExternalMemoryIteratorProxy { | |||
There was a problem hiding this comment.
This is the same as the original one with only label is supported?
trivialfis
reviewed
Jan 20, 2025
|
|
||
| public: | ||
| explicit ExternalMemoryIteratorProxy(jobject jiter): jiter_(jiter) { | ||
| XGProxyDMatrixCreate(&proxy_); |
There was a problem hiding this comment.
These function calls need to be checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new parameter "useExternalMemory" to indicate whether to use external memory when build QuantileDMatrix. If it's set to true, then the cached file will be cached into the directory specified by
spark.local.dir, ifspark.local.diris not set, "/tmp/ will be used for the caching.