This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
Only consider public subnets #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
public_subnets
branch
from
1406dbe to
b9a3025
Compare
This was referenced Feb 13, 2021
|
i suppose this is not addressed as of v20.10.5 because it's still referencing the private subnets in the resulting CF template. :-( as of right now i'm just doing a |
|
in which version of docker cli is this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add ability to detect "public subnets" and only consider those when building the stack's network configuration.
Note: private subnets (i.e. not associated with an Internet Gateway) don't make sense for Docker ECS integration as service would not be able to pull sidecar images from DockerHub.
Related issue
#921
/test-ecs
(not mandatory) A picture of a cute animal, if possible in relation with what you did
