Skip to content

Commit

Permalink
Disable BuildKit's new linting functionality (pre-emptively)
Browse files Browse the repository at this point in the history
I'm not sold on this behavior in general (or the default-provided checks), but image build time is definitely not the place for them (if we were to do something with them, the appropriate place would be a CI check during image/`Dockerfile` review time).
  • Loading branch information
tianon committed Jun 3, 2024
1 parent f26f47a commit cc6279a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .test/meta-commands/out.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ SOURCE_DATE_EPOCH=1700741054 \
--platform 'linux/amd64' \
--build-context 'alpine:3.18=docker-image://alpine@sha256:34871e7290500828b39e22294660bee86d966bc0017544e848dd9a255cdf59e0' \
--build-arg BUILDKIT_SYNTAX="$BASHBREW_BUILDKIT_SYNTAX" \
--build-arg BUILDKIT_DOCKERFILE_CHECK=skip=all \
--file 'Dockerfile' \
'https://github.com/docker-library/docker.git#6d541d27b5dd12639e5a33a675ebca04d3837d74:24/cli'
mkdir temp
Expand Down
1 change: 1 addition & 0 deletions meta.jq
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ def build_command:
| "--build-context " + @sh
),
"--build-arg BUILDKIT_SYNTAX=\"$BASHBREW_BUILDKIT_SYNTAX\"", # TODO .doi/.bin/bashbrew-buildkit-env-setup.sh
"--build-arg BUILDKIT_DOCKERFILE_CHECK=skip=all", # disable linting (https://github.com/moby/buildkit/pull/4962)
@sh "--file \(.source.entry.File)",
($buildUrl | @sh),
empty
Expand Down

0 comments on commit cc6279a

Please sign in to comment.