Save firstTime this build was attempted in past-jobs.json #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Dec 10, 2024
Jenkinsfile.trigger
Outdated
Comment on lines
211
to
212
| # save firstTime if it isn't set yet | ||
| map_values(.firstTime //= .lastTime) * ( env.buildCompletionDataJson | fromjson ) |
There was a problem hiding this comment.
Can't have ' because we're inside ' 😄 also if we split this up the diff is slightly better and it's slightly more obvious that we're adding data and munging data since they're separate
Suggested change
| # save firstTime if it isn't set yet | |
| map_values(.firstTime //= .lastTime) * ( env.buildCompletionDataJson | fromjson ) | |
| . * ( env.buildCompletionDataJson | fromjson ) | |
| # save firstTime if it is not set yet | |
| | map_values(.firstTime //= .lastTime) |
just some extra data so we can see what time this started failing without having to calculate based on skips, count, and assuming the job ran every hour
tianon
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just some extra data so we can see what time this started failing without having to calculate based on skips, count, and assuming the job ran every hour.
I meant to include this in #91, but it got lost in the refactors.
Also drop temporary migration of
pastFailedJobs.jsonsince it isn't necessary anymore.