Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add uniqueness validation to repository remote url #5118

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Add uniqueness validation to repository remote url #5118

merged 3 commits into from
Nov 8, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Nov 7, 2023 •
edited
Loading

This pull request avoids bugs that occur when the same repo is added to dodona twice.

closes #4413

@jorg-vr jorg-vr added the bug Something isn't working label Nov 7, 2023
@jorg-vr jorg-vr self-assigned this Nov 7, 2023
@jorg-vr jorg-vr requested a review from a team as a code owner November 7, 2023 13:24
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team November 7, 2023 13:24
@bmesuere bmesuere requested review from chvp and removed request for niknetniko November 7, 2023 13:50
chvp
chvp requested changes Nov 7, 2023
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually, the linting error is right. A migration should be added to enforce this uniqueness at the database level as well.

@jorg-vr jorg-vr requested a review from chvp November 7, 2023 16:37
@jorg-vr jorg-vr merged commit f8052d3 into main Nov 8, 2023
13 checks passed
@jorg-vr jorg-vr deleted the fix/unique_clone_url branch November 8, 2023 09:41
@jorg-vr jorg-vr mentioned this pull request Nov 8, 2023
Merged
@bmesuere bmesuere added the no-release-notes Pull requests that should not show up in release notes label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
bug Something isn't working no-release-notes Pull requests that should not show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reprocessing repository twice might result into timing related git conflicts
3 participants
@jorg-vr @bmesuere @chvp