-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: submodule #272
fix: submodule #272
Changes from 8 commits
55ed064
52743fa
b85f225
5314a67
5cec278
09eaeac
49afac9
922fb99
e4368f5
16dbaaa
e3000bc
b7fe164
46e6fc3
41a0bf0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
name: Release | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
release_type: | ||
description: "Type of release (prerelease, prepatch, patch, minor, preminor, major)" | ||
required: true | ||
default: "patch" | ||
|
||
jobs: | ||
release: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
|
||
- uses: pnpm/action-setup@v3 | ||
with: | ||
version: 8 | ||
|
||
- name: Configure Git | ||
run: | | ||
git config user.name "${{ github.actor }}" | ||
git config user.email "${{ github.actor }}@users.noreply.github.com" | ||
|
||
- name: "Setup npm for npmjs" | ||
run: | | ||
npm config set registry https://registry.npmjs.org/ | ||
echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > ~/.npmrc | ||
|
||
- name: Install Protobuf Compiler | ||
run: sudo apt-get install -y protobuf-compiler | ||
|
||
- name: Install dependencies | ||
run: pnpm install | ||
|
||
- name: Build packages | ||
run: pnpm run build | ||
|
||
- name: Tag and Publish Packages | ||
run: | | ||
npx lerna version ${{ github.event.inputs.release_type }} --conventional-commits --yes --no-private --force-publish | ||
npx lerna publish from-git --yes --dist-tag ${{ github.event.inputs.release_type == 'preminor' && 'next' || 'latest' }} | ||
|
||
- name: Generate Changelog | ||
run: | | ||
npx lerna-changelog > CHANGELOG.md | ||
|
||
- name: Commit and Push Changelog | ||
run: | | ||
git add CHANGELOG.md | ||
git commit -m "chore(release): update changelog [skip ci]" | ||
git push origin HEAD:${{ github.ref }} | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
[submodule "dojo-starter"] | ||
path = examples/dojo-starter | ||
path = worlds/dojo-starter | ||
url = https://github.com/dojoengine/dojo-starter |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,11 @@ | |
"$schema": "node_modules/lerna/schemas/lerna-schema.json", | ||
"version": "1.0.0-alpha.11", | ||
"packages": ["packages/*", "examples/*"], | ||
"npmClient": "pnpm" | ||
"npmClient": "pnpm", | ||
"command": { | ||
"publish": { | ||
"conventionalCommits": true, | ||
"yes": true | ||
} | ||
} | ||
Comment on lines
+5
to
+11
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM on the The addition of
However, I have a concern about the While
Example: "command": {
"publish": {
"conventionalCommits": true
}
} This way, you can use |
||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -26,6 +26,7 @@ | |||||
"devDependencies": { | ||||||
"tsup": "^8.0.1", | ||||||
"typescript": "^5.5.4", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct TypeScript version The specified TypeScript version "^5.5.4" does not exist as of the current date. This could lead to installation issues or unexpected behavior. Please update the TypeScript version to a valid, current version. For example: "devDependencies": {
"tsup": "^8.0.1",
- "typescript": "^5.5.4",
+ "typescript": "^5.0.4",
"wasm-pack": "^0.12.1",
"vitest": "^2.1.1"
} Verify the latest stable version of TypeScript and use that. Committable suggestion
Suggested change
|
||||||
"wasm-pack": "^0.12.1" | ||||||
"wasm-pack": "^0.12.1", | ||||||
"vitest": "^2.1.1" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Update test script to use Vitest The addition of Vitest as a devDependency is a good step towards implementing tests for this package. However, the current "test" script in your package.json doesn't utilize Vitest. Consider updating the "test" script to use Vitest. Here's a suggested change: "scripts": {
"build-wasm": "cd crate && ./build.sh",
"build": "npm run build-wasm && tsc",
- "test": "echo \"Error: no test specified\" && exit 1"
+ "test": "vitest run"
}, Also, consider adding a "test:watch" script for development: "scripts": {
"build-wasm": "cd crate && ./build.sh",
"build": "npm run build-wasm && tsc",
- "test": "echo \"Error: no test specified\" && exit 1"
+ "test": "vitest run",
+ "test:watch": "vitest"
}, Don't forget to create test files and configure Vitest as needed for your project structure.
|
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Action Required: Update remaining references to the old submodule path.
The following files still reference
examples/dojo-starter
and should be updated toworlds/dojo-starter
:readme.md
cd examples/dojo-starter
cd examples/dojo-starter
examples/example-nodejs-bot/tsconfig.json
"exclude": ["examples/dojo-starter/target/dev/manifest.json"]
Please ensure these paths are updated to reflect the new submodule location to maintain consistency across the project.
Analysis chain
LGTM! Verify consistency across the project.
The change to the submodule path from
examples/dojo-starter
toworlds/dojo-starter
looks good. This appears to be a directory restructuring, which aligns with the PR title "fix: submodule".To ensure consistency across the project, please run the following script to check for any references to the old path:
This script will help identify any potential inconsistencies or references that might need updating due to this path change.
LGTM! Verify no residual references to the old submodule path.
To ensure that there are no remaining references to
examples/dojo-starter
outside of.gitmodules
, please run the following script:Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 587
Script:
Length of output: 394