Remove locks in RadioButton and increase type safety (use generic types) #10251
+64
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes weird branching loops for cleanup, replace them with counting down loops instead.
_groupNameToElements
Hashtable
withDictionary<string, List<WeakReference<RadioButton>>>
.List<WeakReference<RadioButton>>
instead ofArrayList
to store weak references per group name.WeakReference<RadioButton>
instead of untypedWeakReference
._groupNameToElements
tot_groupNameToElements
as itsThreadStatic
variable.Thread
would gets its own copy anyways.Customer Impact
Increased performance, cleaner codebase for developers.
Regression
No.
Testing
Local build, extensive testing with radio buttons.
Risk
Low to medium, I believe I've tested most of the edge cases as I was working on something with the build.
Microsoft Reviewers: Open in CodeFlow