Fix: support configuring the indent_width for markdown files #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bartlomieju
reviewed
Dec 10, 2024
| @@ -8,6 +8,7 @@ use serde::Serialize; | |||
| #[serde(rename_all = "camelCase")] | |||
| pub struct Configuration { | |||
| pub line_width: u32, | |||
| pub indent_width: u32, | |||
There was a problem hiding this comment.
Could you add a test that exercises this option?
…ck if it is working as expected
dsherret
reviewed
Dec 10, 2024
| @@ -49,6 +49,10 @@ impl ConfigurationBuilder { | |||
| self.insert("lineWidth", (value as i32).into()) | |||
| } | |||
|
|
|||
| pub fn indent_width(&mut self, value: u32) -> &mut Self { | |||
| self.insert("indentWidth", (value as i32).into()) | |||
| } | |||
There was a problem hiding this comment.
Have you tested this out? I don't think it will work. I never added indent width to markdown because markdown is very specific about how indentation works. For example, code blocks are 4 spaces and some indent is 3 spaces.
There was a problem hiding this comment.
I will add a test to verify if it works correctly. Thank you for bringing this to my attention.
There was a problem hiding this comment.
@dsherret You’re right. I tried testing it after the modification, but it failed. Do you have any suggestions that could help resolve this issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes denoland/deno#26863
This PR supports configuring the indent width for markdown files.