Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gcs #3746

Closed
wants to merge 7 commits into from
Closed

feat: support gcs #3746

wants to merge 7 commits into from

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Jan 6, 2025

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: Jim Ma <[email protected]>
@jim3ma jim3ma requested a review from a team as a code owner January 6, 2025 09:59
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 37.67123% with 91 lines in your changes missing coverage. Please review.

Project coverage is 35.13%. Comparing base (cc4abed) to head (a92bcb9).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...kg/source/clients/gcsprotocol/gcs_source_client.go 37.67% 80 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3746      +/-   ##
==========================================
- Coverage   35.21%   35.13%   -0.09%     
==========================================
  Files         336      337       +1     
  Lines       37852    37998     +146     
==========================================
+ Hits        13330    13350      +20     
- Misses      23697    23805     +108     
- Partials      825      843      +18     
Flag Coverage Δ
unittests 35.13% <37.67%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pkg/source/source_client_builder.go 0.00% <ø> (ø)
...kg/source/clients/gcsprotocol/gcs_source_client.go 37.67% <37.67%> (ø)

... and 6 files with indirect coverage changes

@jim3ma jim3ma closed this Jan 9, 2025
@jim3ma jim3ma deleted the feat/support-gcs branch January 9, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant