Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize snapshots storage #234

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Optimize snapshots storage #234

wants to merge 16 commits into from
+941 −100

Conversation

ValentaTomas
Copy link
Member

@ValentaTomas ValentaTomas commented Jan 9, 2025 •
edited
Loading

Optimize snapshot storage in preparation to enable the automatic pausing of snapshots.

Subtasks:

  • Handle empty block in orchestrator (was already implemented)
  • Skip empty blocks during snapshotting
    • Memfile (untested)
    • Rootfs (lower priority)
  • Skip unchanged blocks during snapshotting
    • Memfile (untested)
  • Start creating empty blocks during template building and upload diff with header instead of the full template
    • Memfile (untested)
    • Rootfs (untested)
  • Handle diffs instead of just full snapshots in orchestrator for normal sandbox start (right now we handle diffs only for resume)

@ValentaTomas ValentaTomas added the improvement Improvement for current functionality label Jan 9, 2025
@ValentaTomas ValentaTomas self-assigned this Jan 9, 2025
@linear Linear
Copy link

linear bot commented Jan 9, 2025

E2B-1423 Optimize snapshots storage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubno jakubno Awaiting requested review from jakubno jakubno will be requested when the pull request is marked ready for review jakubno is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ValentaTomas ValentaTomas

Labels
improvement Improvement for current functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValentaTomas @dobrac @jakubno