Skip to content

Commit

Permalink
fix(ebay-combobox): floating label type (#2370)
Browse files Browse the repository at this point in the history
  • Loading branch information
MaiDeveloper authored Jan 15, 2025
1 parent b4b9899 commit 674712a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/sharp-bees-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ebay/ebayui-core": patch
---

TS fix for combobox
4 changes: 2 additions & 2 deletions src/components/ebay-combobox/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import Expander from "makeup-expander";
import { scroll } from "../../common/element-scroll";
import * as eventUtils from "../../common/event-utils";
import safeRegex from "../../common/build-safe-regex";
import type { AttrClass } from "marko/tags-html";
import type { AttrClass, AttrString } from "marko/tags-html";
import type { WithNormalizedProps } from "../../global";

export interface ComboboxOption {
Expand All @@ -26,7 +26,7 @@ interface ComboboxInput extends Omit<Marko.Input<"input">, `on${string}`> {
fluid?: boolean;
autocomplete?: "list" | "none";
"list-selection"?: "manual" | "automatic";
"floating-label"?: boolean;
"floating-label"?: AttrString;
"view-all-options"?: boolean;
button?: Marko.Input<"button"> &
Marko.AttrTag<{
Expand Down

0 comments on commit 674712a

Please sign in to comment.