fix(ebay-carousel): fix width calculation for last pill when font not loaded (#2344) #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0debd3a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WinkeeFace
force-pushed
the
2344-ebay-carousel-the-last-pill-is-partially-hidden-due-to-wrong-width-calculation
branch
from
466335f to
c182a12
Compare
WinkeeFace
force-pushed
the
2344-ebay-carousel-the-last-pill-is-partially-hidden-due-to-wrong-width-calculation
branch
from
c182a12 to
0debd3a
Compare
agliga
approved these changes
Dec 20, 2024
agliga
deleted the
2344-ebay-carousel-the-last-pill-is-partially-hidden-due-to-wrong-width-calculation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where the last pill in the
ebay-carouselis partially hidden due to incorrect width calculation. The issue occurs because the width is calculated before the correct font (Market Sans) finishes loading, causing the fallback font (Arial) to be used during calculations.The changes ensure the component waits for the font to be fully loaded before performing width calculations. This prevents rendering issues and ensures the correct width is applied.
Context
The bug was reproduced on production. However, since this is a rendering issue caused by width calculations happening before the font is loaded, it is nearly impossible to reliably test locally.
These changes introduce logic to:
This approach ensures stability and resolves the issue effectively.
References
Screenshots
Before:
Screenshot not provided after the fix due to the nature of the rendering issue. The problem was reproduced in production, but it is difficult to capture accurately for testing locally.
Checklist