[21114] Check suprocess return codes on RDT generation (backport #795) #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
7 tasks
|
@richiprosima Please test docs |
|
This shall include changes similar to those introduced in: |
Signed-off-by: eduponz <[email protected]> (cherry picked from commit 0974196) Check suprocess return codes on RDT generation (#795) (#796) * Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <[email protected]> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <[email protected]> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <[email protected]> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <[email protected]> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <[email protected]> --------- Signed-off-by: eduponz <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
Signed-off-by: eduponz <[email protected]>
EduPonz
force-pushed
the
mergify/bp/2.10.x/pr-795
branch
from
6c16374 to
f5345b9
Compare
MiguelCompany
previously approved these changes
Jul 3, 2024
EduPonz
force-pushed
the
mergify/bp/2.10.x/pr-795
branch
from
f5345b9 to
938f5d7
Compare
MiguelCompany
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the RDT generation to fail if either of the
doxygenorswigcommands fails. Not checking them was causing the documentation to build with API reference errors.@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Related implementation PR:
NOTE: As RTD build is not ready to take the appropriate Fast DDS branch and will choose
master, the build will failed until eProsima/Fast-DDS#4896 is merged. I've verified on a Ubuntu 20.04 docker that the doxygen is generated without errors with that Fast DDS PR.Contributor Checklist
Reviewer Checklist
This is an automatic backport of pull request #795 done by [Mergify](https://mergify.com).