Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21319] Add python optional step in binary installation sections #853

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[21319] Add python optional step in binary installation sections #853

merged 1 commit into from
Jul 10, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 8, 2024 •
edited by Mario-DL
Loading

Description

There were missing instructions regarding Fast DDS CLI in binary installation sections.
This PR adds that section in both Linux and Windows.

@Mergifyio backport 2.14.x 2.13.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jul 8, 2024
@JesusPoderoso JesusPoderoso requested a review from Mario-DL July 8, 2024 14:52
@JesusPoderoso JesusPoderoso self-assigned this Jul 8, 2024
Mario-DL
Mario-DL previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets see if we can fix the ci and run it

@JesusPoderoso JesusPoderoso requested a review from Mario-DL July 10, 2024 06:27
@JesusPoderoso JesusPoderoso requested review from Mario-DL and removed request for Mario-DL July 10, 2024 08:27
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.14.x 2.13.x 2.10.x

@mergify Mergify
Copy link

mergify bot commented Jul 10, 2024 •
edited
Loading

backport 2.14.x 2.13.x 2.10.x

✅ Backports have been created

@EduPonz EduPonz merged commit 4fa7593 into master Jul 10, 2024
4 checks passed
@EduPonz EduPonz deleted the hotfix/21319 branch July 10, 2024 09:26
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@JesusPoderoso @mergify
Add python optional step in binary installation sections (#853)
5f849e8 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@JesusPoderoso @mergify
Add python optional step in binary installation sections (#853)
e988a0a 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
7 tasks
mergify bot pushed a commit that referenced this pull request Jul 10, 2024
@JesusPoderoso @mergify
Add python optional step in binary installation sections (#853)
4f31345 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
7 tasks
JesusPoderoso added a commit that referenced this pull request Jul 10, 2024
@mergify @JesusPoderoso
Add python optional step in binary installation sections (#853) (#861)
a582352 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)

Co-authored-by: Jesús Poderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Jul 10, 2024
@mergify @JesusPoderoso
Add python optional step in binary installation sections (#853) (#863)
baa84d1 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)

Co-authored-by: Jesús Poderoso <[email protected]>
EduPonz pushed a commit that referenced this pull request Jul 10, 2024
@mergify @JesusPoderoso
Add python optional step in binary installation sections (#853) (#862)
79dd6ef 
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 4fa7593)

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @Mario-DL @EduPonz