[22463] Fix Discovery CLI Tool in Windows (No privileges)

[cferreiragonz]

Description

When Fast DDS is compiled without admin privileges, no symlink is created to link to the fast-discovery-server-1.0.1.exe file. In this case, an alternative .bat is created to call the tool. However, the .bat file contains an error and fails to properly call the tool because it adds an unknown parameter as argument. To solve this, the .bat file was removed and the .exe file is called from the Python script directly. This gives more control over the tool as it does not bypass the Python script when compiling without admin privileges.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

• Commit messages follow the project guidelines.
• The code follows the style guidelines of this project.
• Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
• N/A Any new/modified methods have been properly documented using Doxygen.
• N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
• Changes are backport compatible: they do NOT break ABI nor change library core behavior.
• Changes are API compatible.
• N/A New feature has been added to the versions.md file (if applicable).
• N/A New feature has been documented/Current behavior is correctly described in the documentation.
• Applicable backports have been included in the description.

Reviewer Checklist

• The PR has a milestone assigned.
• The title and description correctly express the PR's purpose.
• Check contributor checklist is correct.
• If this is a critical bug fix, backports to the critical-only supported branches have been requested.
• Check CI results: changes do not issue any warning.
• Check CI results: failing tests are unrelated with the changes.

[Mario-DL]

Nice addition, I think getting rid of the .bat file makes sense.
Changes LGTM and tested in my local.

We would need to add psutil to the windows and mac reusable workflows just at the point where we specify the required Python dependencies vcstool xmlschema

[Mario-DL]

LGTM with green CI

[cferreiragonz]

@Mergifyio backport 3.1.x 3.0.x

[mergify]

backport 3.1.x 3.0.x

✅ Backports have been created

• #5509 [22463] Fix Discovery CLI Tool in Windows (No privileges) (backport #5493) has been created for branch 3.1.x but encountered conflicts
• #5510 [22463] Fix Discovery CLI Tool in Windows (No privileges) (backport #5493) has been created for branch 3.0.x but encountered conflicts