Change how unspecified ... arguments are passed to other functions

NEWS.md

@@ -15,6 +15,11 @@ Minor changes
 * `report` now supports reporting of BayesFactor objects with variables of class `BFBayesFactor`.
 * `report_sample()` now suggests valid column names for misspelled columns in the `select`, `by`, `weights` and `exclude` arguments.
 
+Bug fixes
+
+* Fixed issues with incorrectly passing additional arguments to downstream
+  functions in `report()` for `htest` objects.
+
 # report 0.5.8
 
 New features

R/report_htest_chi2.R

@@ -9,15 +9,15 @@
 # report_effectsize ---------------------
 
 .report_effectsize_chi2 <- function(x, table, dot_args, rules = "funder2019") {
   if (chi2_type(x) %in% c("pearson", "probabilities")) {
     args <- c(list(x), dot_args)
     table <- do.call(effectsize::effectsize, args)
     table_footer <- attributes(table)$table_footer
     ci <- attributes(table)$ci
     estimate <- names(table)[1]
     rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-    args <- list(table, rules = rules, dot_args)
+    args <- c(list(table, rules = rules), dot_args)
     interpretation <- do.call(effectsize::interpret, args)$Interpretation
     rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))
   } else {
@@ -26,7 +26,7 @@
     ), call. = FALSE)
   }
 
   if (estimate == "Cramers_v_adjusted") {
     main <- paste0("Adjusted Cramer's v = ", insight::format_value(table[[estimate]]))
   } else if (estimate == "Fei") {
     main <- paste0("Fei = ", insight::format_value(table[[estimate]]))
@@ -76,10 +76,10 @@
 .report_model_chi2 <- function(x, table) {
   if (chi2_type(x) == "pearson") {
     type <- " of independence between"
     vars_full <- paste0(names(attributes(x$observed)$dimnames), collapse = " and ")
   } else if (chi2_type(x) == "probabilities") {
     type <- " / goodness of fit of "
     dist <- ifelse(
       grepl("non", attr(table, "table_footer"), fixed = TRUE), "a uniform distribution",
       paste0("a distribution of [", paste0(
         names(x$expected), ": n=", x$expected,
@@ -90,7 +90,7 @@
     vars_full <- paste(x$data.name, "to", dist)
   }
 
   text <- paste0(
     trimws(x$method),
     type,
     paste0(" ", vars_full)

R/report_htest_fisher.R

@@ -9,17 +9,17 @@
 # report_effectsize ---------------------
 
 .report_effectsize_fisher <- function(x, table, dot_args, rules = "funder2019") {
   args <- c(list(x), dot_args)
   table <- do.call(effectsize::effectsize, args)
   ci <- attributes(table)$ci
   estimate <- names(table)[1]
   rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-  args <- list(table, rules = rules, dot_args)
+  args <- c(list(table, rules = rules), dot_args)
   interpretation <- do.call(effectsize::interpret, args)$Interpretation
   rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))
 
   if (estimate == "Cramers_v_adjusted") {
     main <- paste0("Adjusted Cramer's v = ", insight::format_value(table[[estimate]]))
   } else if (estimate == "Tschuprows_t") {
     main <- paste0("Tschuprow's t = ", insight::format_value(table[[estimate]]))

R/report_htest_ttest.R

@@ -50,7 +50,7 @@
   estimate <- names(table)[1]
   rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)
 
-  my_args <- list(table, rules = rules, dot_args)
+  my_args <- c(list(table, rules = rules), dot_args)
   interpretation <- do.call(effectsize::interpret, my_args)$Interpretation
   rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))