Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on checkSemanticId() #136

Merged
merged 7 commits into from
Dec 16, 2024
Merged

Work on checkSemanticId() #136

merged 7 commits into from
Dec 16, 2024

Conversation

seicke
Copy link
Member

@seicke seicke commented Dec 8, 2024 •
edited
Loading

  • Add tests for IEC CDD semanticId (preparatory work for [FEATURE] SMT DigitalNameplate v3 Visualization #118 )
  • Add tests for IRIs inlcuding version at the end
  • Add tests for IRIs with and without ending /
  • Add further tests for Eclass cardinality
  • Fix for Eclass cardinality

seicke added 2 commits December 8, 2024 11:09
@seicke
Add check (and test) for IEC CDD semanticIds
4e6289b
@seicke
Work on checkSemanticId
9630d84 
Add tests for IEC CDD semanticId
Add further tests for Eclass cardinality
Fix for Eclass cardinality
@seicke seicke changed the title Extend checkSemanticId for IEC CDD IRDIs Work on checkSemanticId() Dec 8, 2024
aaronzi
aaronzi requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Could you please extract the different types of SemanticIds in their own sub-functions for better readability.

aaronzi
aaronzi requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@aaronzi aaronzi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add the possibility to add custom SemanticIds that don't follow the CDD or Eclass patterns and include this in your tests?

@aaronzi aaronzi merged commit 4cee279 into eclipse-basyx:main Dec 16, 2024
2 checks passed
@seicke seicke deleted the iec-cdd-semanticId branch December 18, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronzi aaronzi aaronzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seicke @aaronzi