-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates SM visualization compontents to the composition API #176
base: main
Are you sure you want to change the base?
Conversation
@aaronzi Before I continue with my work on the further visualizations, may I ask you to pre-review the nameplate visualization? Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THank you for the PR. I added some remarks as comments to the respective lines in the code.
aas-web-ui/src/components/Plugins/Submodels/ContactInformation.vue
Outdated
Show resolved
Hide resolved
aas-web-ui/src/components/Plugins/Submodels/ContactInformation.vue
Outdated
Show resolved
Hide resolved
aas-web-ui/src/components/Plugins/Submodels/HandoverDocumentation.vue
Outdated
Show resolved
Hide resolved
Add tests for SemanticIdUtils
… as well as semanticId of SMC
Simplify determination of MultiLanguageProperty values
Create composable for virtual contact file
Add "iso-639-1" package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements!
For now, I have another two major remarks:
- I would prefer not to include another icon dependency. I don't think that flag icons add a big benefit here and they increase the package size by a lot.
- I noticed that now Plugins are only rendered after all the data has loaded and is available. This makes the skeleton loaders in those plugins irrelevant and increases the time before the user can see components drastically. This also includes long blocking times for the DOM since the rendering needs to wait for asynchronous actions like fetching the data from a server.
…pesOfEmailAddress
This PR
CountryOfOrigin
for determining country name (also show country flag)NationalCode
for determining country name (also show country flag)Language
code for determining language nameNote: Transfer of TimeSeries v1.1 visualization to the composition API in PR #186