Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates SM visualization compontents to the composition API #176

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from

Conversation

seicke
Copy link
Member

@seicke seicke commented Dec 22, 2024

This PR

  • Renames SM Visualization components (closes [TICKET] Adapt file name of SM Visualizations #160)
  • Adds visualization header component
  • Adds diverse utils
  • Improves Nameplate v2 visualization
    • Address determination
    • vCard determination
    • Consideration of the CountryOfOrigin for determining country name (also show country flag)
  • Improves for ContactInformations v1 visualization
    • Address determination
    • vCard determination
    • Consideration of the NationalCode for determining country name (also show country flag)
    • Consideration of Language code for determining language name
  • Improves TechnicalData v1.2 visualization
  • Improves HandoverDocumentation v1.2 visualization
  • Improves HierarchicalStructures v1.x visualization
  • Harmonizes code of all SM visualization
  • Closes [FEATURE] Show description or displayName (instead of idShort) if available in BOM Visualization #171

Note: Transfer of TimeSeries v1.1 visualization to the composition API in PR #186

@seicke seicke changed the title Updates visualization compontents to the composition API Updates SM visualization compontents to the composition API Dec 22, 2024
@seicke
Copy link
Member Author

seicke commented Dec 23, 2024

@aaronzi Before I continue with my work on the further visualizations, may I ask you to pre-review the nameplate visualization? Thanks in advance!

Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THank you for the PR. I added some remarks as comments to the respective lines in the code.

aas-web-ui/src/components/ComponentVisualization.vue Outdated Show resolved Hide resolved
aas-web-ui/tsconfig.tsbuildinfo Outdated Show resolved Hide resolved
@seicke seicke marked this pull request as ready for review December 29, 2024 06:18
@seicke seicke requested a review from aaronzi December 29, 2024 06:19
Copy link
Member

@aaronzi aaronzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements!

For now, I have another two major remarks:

  1. I would prefer not to include another icon dependency. I don't think that flag icons add a big benefit here and they increase the package size by a lot.
  2. I noticed that now Plugins are only rendered after all the data has loaded and is available. This makes the skeleton loaders in those plugins irrelevant and increases the time before the user can see components drastically. This also includes long blocking times for the DOM since the rendering needs to wait for asynchronous actions like fetching the data from a server.

@seicke seicke marked this pull request as draft January 10, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants