mypy.ini: remove mypy.ini after fixing imports such that the config i…

…s no more needed. .github/workflows/ci.yml: add line. sdk/basyx/tutorial_objectstore.py: fix import. sdk/test/test_objectstore.py: remove type ignores. sdk/basyx/__init__.py: add init for tutorial folder
eclipse-basyx · Sep 13, 2024 · f796755 · f796755
1 parent 18e9317
commit f796755
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -115,4 +115,4 @@ jobs:
       run: |
         ls
         cd ./sdk
-        python -m build
+        python -m build
diff --git a/.gitignore b/.gitignore
@@ -16,6 +16,7 @@ sdk/basyx_python_framework.egg-info/
 /sdk/build
 /dist/
 /*.egg-info/
+sdk/*.egg-info/
 /docs/build/
 
 # Coverage artifacts

diff --git a/mypy.ini b/mypy.ini
diff --git a/sdk/basyx/tutorial/__init__.py b/sdk/basyx/tutorial/__init__.py
diff --git a/sdk/basyx/tutorial/tutorial_objectstore.py b/sdk/basyx/tutorial/tutorial_objectstore.py
@@ -5,7 +5,7 @@
 #
 # SPDX-License-Identifier: MIT
 
-from sdk.basyx.object_store import ObjectStore
+from basyx.object_store import ObjectStore
 from aas_core3.types import Identifiable, AssetAdministrationShell, AssetInformation, AssetKind
 import aas_core3.types as aas_types
 

diff --git a/sdk/test/test_objectstore.py b/sdk/test/test_objectstore.py
@@ -7,7 +7,7 @@
 
 import unittest
 
-from basyx.object_store import ObjectStore, ObjectProviderMultiplexer  # type: ignore
+from basyx.object_store import ObjectStore, ObjectProviderMultiplexer
 from aas_core3.types import Identifiable, AssetAdministrationShell, AssetInformation, AssetKind
 import aas_core3.types as aas_types
 
@@ -20,6 +20,9 @@ def setUp(self) -> None:
         self.aas2 = AssetAdministrationShell(id="urn:x-test:aas2",
                                              asset_information=AssetInformation(asset_kind=AssetKind.TYPE))
 
+        self.aas3 = AssetAdministrationShell(id="urn:x-test:aas3",
+                                             asset_information=AssetInformation(asset_kind=AssetKind.TYPE))
+
         some_element = aas_types.Property(
             id_short="some_property",
             value_type=aas_types.DataTypeDefXSD.INT,
@@ -69,8 +72,7 @@ def test_store_retrieve(self) -> None:
         object_store.add(self.aas1)
         object_store.add(self.aas2)
         self.assertIn(self.aas1, object_store)
-        property = aas_types.Property('test')  # type: ignore
-        self.assertFalse(property in object_store)
+        self.assertFalse(self.aas3 in object_store)
         aas3 = AssetAdministrationShell(id="urn:x-test:aas1", asset_information=AssetInformation(
             global_asset_id="http://acplt.org/TestAsset/", asset_kind=AssetKind.NOT_APPLICABLE))
         with self.assertRaises(KeyError) as cm: