Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import constants from @devfile/api (#1280) #1292

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: import constants from @devfile/api (#1280) #1292

merged 1 commit into from
Jan 14, 2025

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

cherry-pick from #1280

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Is it tested? How?

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Jan 14, 2025

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1292

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1292", name: che-dashboard}]}}]"

@dmytro-ndp dmytro-ndp self-requested a review January 14, 2025 11:12
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR tested successfully using quay.io/eclipse/che-dashboard:pr-1292 + Dev Spaces 3.18.0.RC-22 :

  • Empty workspace and workspace from factory URL created successfully.
  • List of workspaces fetched correctly as well.

Screenshot from 2025-01-14 13-13-24

Copy link

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dmytro-ndp, vinokurig

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vinokurig vinokurig merged commit 6636a3f into 7.95.x Jan 14, 2025
14 checks passed
@vinokurig vinokurig deleted the 7.95.x_1 branch January 14, 2025 11:34
@devspacesbuild
Copy link

Build 3.18 :: dashboard_3.18/7: Console, Changes, Git Data

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

Build 3.18 :: dashboard_3.18/7: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/338 triggered

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devspacesbuild
Copy link

@devstudio-release
Copy link

Build 3.18 :: copyIIBsToQuay/2890: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: get-sources-rhpkg-container-build_3.18/347: SUCCESS

devspaces-operator-bundle : 3.18 :: Build 66374584 : quay.io/devspaces/devspaces-operator-bundle:3.18-23
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.18/27 triggered;
Bundle CSV related images:

@devspacesbuild
Copy link

Build 3.18 :: sync-to-downstream_3.18/339: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.18/347 triggered; /job/DS_CI/job/dsc_3.18 triggered;

@devspacesbuild
Copy link

Build 3.18 :: operator-bundle_3.18/290: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.18/339 triggered

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/3: Console, Changes, Git Data

@devspacesbuild
Copy link

Build 3.18 :: update-digests_3.18/306: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.18/290 triggered

@devspacesbuild
Copy link

Build 3.18 :: dsc_3.18/3: SUCCESS

3.18.0-CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants