Addresses #155: Typifysearch #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this cleanup the figure and edipart search was typified. As part of this work it was identified that the TargetingTool documentation was wrong. While there it was written that getExclusion set provides editparts all its children provided a list of IFigures. Also the search expected IFigures. Furthermore AbstractTransferDropTargetListener delivered EditParts but the search required IFigures. The code was fixed here was well and by typifying the Collections it is now clearer.
|
As there were no objections I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this cleanup the figure and edipart search was typified. As part of
this work it was identified that the TargetingTool documentation was
wrong. While there it was written that getExclusion set provides
editparts all its children provided a list of IFigures. Also the search
expected IFigures.
Furthermore AbstractTransferDropTargetListener delivered EditParts but
the search required IFigures. The code was fixed here was well and by
typifying the Collections it is now clearer.
@Destrolaric this would be my last commit for Issue #155 for now.