Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modernize Code] Use typed generics for RankList #242

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

azoitl
Copy link
Contributor

@azoitl azoitl commented Aug 15, 2023

In addition implemented Iterable interface to allow forEach and ranged for loops on RankLists.

Addresses #155

@ptziegler @Destrolaric this would be my last clean-up for the main draw2d graph classes

In addition implemented Iterable interface to allow forEach and ranged
for loops on RankLists.
@github-actions
Copy link

Unit Test Results

    9 files      9 suites   16s ⏱️
307 tests 305 ✔️ 2 💤 0
921 runs  915 ✔️ 6 💤 0

Results for commit ac6740d.

Copy link
Contributor

@ptziegler ptziegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straightforward to me

@azoitl
Copy link
Contributor Author

azoitl commented Aug 16, 2023

Looks pretty straightforward to me

Thx.

@azoitl azoitl merged commit 24e1900 into eclipse-gef:master Aug 16, 2023
@azoitl azoitl deleted the typed_ranklist branch August 16, 2023 21:46
@azoitl azoitl added this to the 3.17.0 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants