[Modernize Code] clean-ups in AbstractEditPartViewer #287
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
As tomorrow is deadline for RC1 I would love to merge it. As its mostly internal clean-ups I would merge it if no one objects. |
There was a problem hiding this comment.
The change itself looks fine. However keep in mind that this might cause compilation errors in downstream projects.
For the RC1, I had to adjust the WindowBuilder code to resolve compilation errors due to 0860312
In order to avoid any unpleasant surprises directly after the release, this would now require downstream projects to build/test against the upcoming RC1, which I'm not sure everyone is doing.
Granted, primGetSelectedEditParts() is a protected method, so the chances of complications are probably low, but I think that's something we should keep in mind.
|
@ptziegler good point I'll better keep it for 3.19.0 |
|
As we are at the start of the new dev cycle I'll merge this early to get early feedback. Tested at least with 4diac IDE and GMF Runtime. |
Addresses #155