Typify MultiValueMap and fix warnings in AutomaticRouter #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
force-pushed
the
typify-mutlti-value-map
branch
from
53c4df9 to
894d353
Compare
azoitl
requested changes
Dec 14, 2023
The MultiValueMap used to be backed by a map with either a list or a single object as value. This part has been adapted so that the map always contains a list of values. While this adds a small overhead when filling the map, it should in return reduce the overhead when calling the getter for values with only a single element. Reduces the total amount of warnings by ~20.
ptziegler
force-pushed
the
typify-mutlti-value-map
branch
from
894d353 to
03f78cc
Compare
azoitl
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MultiValueMap used to be backed by a map with either a list or a single object as value.
This part has been adapted so that the map always contains a list of values. While this adds a small overhead when filling the map, it should in return reduce the overhead when calling the getter for values with only a single element.
Reduces the total amount of warnings by ~20.