New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center LED text in display and adjust font size #675

Merged

azoitl merged 1 commit into eclipse-gef:master from Amadeus1791:center-led-number

Jan 19, 2025

Contributor

Amadeus1791 commented Jan 19, 2025

This PR addresses two issues with the LED text display:

Misaligned text: Introduced dynamic positioning (including padding and offset constants) to ensure the text is centered within the display rectangle.
Oversized font: Reduced the font size from 38 to 23 to ensure the displayed number does not appear too large.

Before: (on 3840x2160 resolution, 150%scaling, Windows)

After:


          Center LED text in display and adjust font size

dd1f11d

Signed-off-by: Amadeus1791 <[email protected]>

azoitl approved these changes

View reviewed changes

Contributor

azoitl left a comment

Looks also good on a normal laptop screen with 100% native scaling on Linux/GTK.

azoitl merged commit 0721054 into eclipse-gef:master

14 checks passed

ptziegler added this to the 3.23.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet