Retire org.eclipse.jdt.annotation v1

[vogella]

What it does

How to test

Author checklist

• I have thoroughly tested my changes
• The change is following the coding conventions
• I have signed the Eclipse Contributor Agreement (ECA)

[jukzi]

If there is no objection from anyone i would merge this PR next week.

[srikanth-sankaran]

If there is no objection from anyone i would merge this PR next week.

@stephan-herrmann - I think you are the best person to greelight this. I am hoping this will clear the 7 soft errors and 2 warnings I am seeing in jdt-core development workspace. Soft as in they show up in problems marker view but don't seem to impact anything else.

The major version should be incremented in version 1.2.100, since API breakage occurred since version 2.3.100
The method org.eclipse.jdt.annotation.NonNullByDefault.value() without a default value has been removed
The type org.eclipse.jdt.annotation.Checks has been removed from org.eclipse.jdt.annotation_1.2.100
The type org.eclipse.jdt.annotation.DefaultLocation has been removed from org.eclipse.jdt.annotation_1.2.100
The type org.eclipse.jdt.annotation.NotOwning has been removed from org.eclipse.jdt.annotation_1.2.100
The type org.eclipse.jdt.annotation.Owning has been removed from org.eclipse.jdt.annotation_1.2.100
Missing @SInCE tag on value()
Build path specifies execution environment JavaSE-1.8. There are no JREs installed in the workspace that are strictly compatible with this environment.
The compiler compliance specified is 1.8 but a JRE 23 is used

[jukzi]

i interpret the silence as no objection. The classes in
org.eclipse.jdt.annotation_v1/src/org/eclipse/jdt/annotation
seem to be old duplicates of
org.eclipse.jdt.annotation\src\org\eclipse\jdt\annotation

[stephan-herrmann]

i interpret the silence as no objection. The classes in org.eclipse.jdt.annotation_v1/src/org/eclipse/jdt/annotation seem to be old duplicates of org.eclipse.jdt.annotation\src\org\eclipse\jdt\annotation

The reasoning is weak, but fortunately the action is OK.

For background see

• The split package org.eclipse.jdt.annotation has jar signature problems: #3027
  • Specifically: The split package org.eclipse.jdt.annotation has jar signature problems: #3027 (comment)
• Stop including including org.eclipse.jdt.annotation_v1 eclipse.jdt#118
• Exclude org.eclipse.jdt.annotation_v1 from workspace in JDT.setup eclipse.jdt#124

After those last two in the list, this bundle effectively was retired already :)