Stop dealing with JLS2 in JLS 3,4,8 tests #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only verifies that "some" AST is being created and is being discarded without any further assertions in order to create the JLS3 one.
This only verifies that "some" AST is being created and is being discarded without any further assertions in order to create the JLS4 one.
This only verifies that "some" AST is being created and is being discarded without any further assertions in order to create the JLS8 one.
akurtakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All that it does is to verify that some AST is created for JLS2 but not checking any of the content which makes it pretty useless.
It's a spin-off from #3533 to get "independent" parts in that are beneficial no matter when that one is done.