Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraneous text block conversion from StringBuffer/StringBuilder #1947

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

jjohnstn
Copy link
Contributor

What it does

See issue.

How to test

See issue or new tests.

Author checklist

- add check for number of string literals to new logic that converts
  the initializer of the StringBuilder/StringBuffer
- modify test in CleanUpTest15
- modify test in AssistQuickFixTest15
- fixes eclipse-jdt#1944
@jjohnstn jjohnstn self-assigned this Jan 16, 2025
@jjohnstn jjohnstn added the bug Something isn't working label Jan 16, 2025
@jjohnstn jjohnstn added this to the 4.35 M2 milestone Jan 16, 2025
@jjohnstn jjohnstn merged commit 3cff735 into eclipse-jdt:master Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert String/... concatenation to Text Block results in incorrect conversion
1 participant