Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate #674: Postpone long-running operations to the activation of the "Tracing" tab. #946

Conversation

fedejeanne
Copy link
Contributor

@fedejeanne fedejeanne commented Nov 29, 2023

Don't start unnecessary operations that only concern the "Tracing" tab
upon initialization of the PDE-Run configuration (in the dialog "Run
configurations..."). Instead, only do them when the tab is first
selected. This speeds up opening the dialog "Run configurations..." (and
also switching to a PDE-Run configuration when the dialog is already
opened).

Show a progress indicator when doing some (possibly) long-running
operations in the "Tracing" tab.

Fixes to eclipse-pde#679
Copy link

Test Results

     270 files  +       6       270 suites  +6   56m 37s ⏱️ + 12m 28s
  3 327 tests ±       0    3 297 ✔️ +       2  30 💤 ±  0  0  - 2 
10 278 runs  +2 701  10 188 ✔️ +2 679  90 💤 +24  0  - 2 

Results for commit dab29a8. ± Comparison against base commit ebba53b.

@fedejeanne
Copy link
Contributor Author

Ready to merge.

@vogella ? :-)

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you.

@HannesWell HannesWell merged commit f2b9ed7 into eclipse-pde:master Nov 29, 2023
14 checks passed
@fedejeanne fedejeanne deleted the enhancements/recreate_674_show_progress_in_run_config_dialog branch November 29, 2023 12:17
@vogella
Copy link
Contributor

vogella commented Nov 29, 2023

Yeah! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants