Restore recursive behavior of AbstractTreeViwer#internalExpandToLevel() #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 1 818 files ± 0 1 818 suites ±0 1h 37m 50s ⏱️ + 6m 47s For more details on these failures, see this check. Results for commit 9bea968. ± Comparison against base commit d4aa37b. ♻️ This comment has been updated with latest results. |
HeikoKlare
force-pushed
the
abstracttreeviewer-regression
branch
4 times, most recently
from
f0e7a51 to
4d46497
Compare
fedejeanne
reviewed
Jan 16, 2025
tests/org.eclipse.jface.tests/src/org/eclipse/jface/tests/viewers/TreeViewerTest.java
Show resolved
Hide resolved
The method AbstractTreeViewer#internalExpandToLevel() used be a recursively called method (by implementation and specification). As a protected method, it is part of the API. With a recent change, the method was changed to delegate to a different method, removing it's recursive property. Consumers that have created subtypes of the AbstractTreeViewer and rely the recursive behavior of that method by overwriting it face a regression by that change. This change restores the existing, recursive behavior of that method while still keeping the reuse of the implementation across other use cases. A test case ensuring the contractual recursive execution is added.
HeikoKlare
force-pushed
the
abstracttreeviewer-regression
branch
from
4d46497 to
9bea968
Compare
I have adapted the PR to include the performance improvement (but putting more of the custom expansion functionality in the lambda). Can you have another look whether that properly reflects your improvement, @fedejeanne? |
fedejeanne
approved these changes
Jan 16, 2025
|
Test failure is unrelated: #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
AbstractTreeViewer#internalExpandToLevel()used be a recursively called method (by implementation and specification). As a protected method, it is part of the API.With a recent change (see #1072), the method was changed to delegate to a different method, removing it's recursive property. Consumers that have created subtypes of the AbstractTreeViewer and rely the recursive behavior of that method by overwriting it face a regression by that change.
This change restores the existing, recursive behavior of that method while still keeping the reuse of the implementation across other use cases. A test case ensuring the contractual recursive execution is added.