Un-deprecate ListSelectionDialog constructor #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecation has been done when Builder was added which seems to be a trend in the Java world. Undeprecation is done now as : * it's one of the very few (if there are any others) APIs that "mandate" going through a builder, which makes it inconsistent with rest * documentation hasn't been adjusted accordingly (even the class level javadoc has example using the deprecated constructor) * usages in the SDK hasn't been migrated to the builder approach (for years) thus generating a number of deprecation warnings Deprecation could be added again whenever the previous issues are resolved.
Test Results 1 818 files ±0 1 818 suites ±0 1h 28m 38s ⏱️ - 1m 36s For more details on these failures, see this check. Results for commit da92c3c. ± Comparison against base commit d6af2f2. |
|
Failing test unrelated to un-deprecation of API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation has been done when Builder was added which seems to be a trend in the Java world.
Undeprecation is done now as :
generating a number of deprecation warnings
Deprecation could be added again whenever the previous issues are resolved.