Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java NIO in tests #1679

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Use Java NIO in tests #1679

merged 2 commits into from
Jan 13, 2025

Conversation

akurtakov
Copy link
Member

No description provided.

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Jan 13, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

resources/tests/org.eclipse.core.tests.resources.saveparticipant1/META-INF/MANIFEST.MF
resources/tests/org.eclipse.core.tests.resources.saveparticipant2/META-INF/MANIFEST.MF
resources/tests/org.eclipse.core.tests.resources.saveparticipant3/META-INF/MANIFEST.MF
resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
resources/tests/org.eclipse.core.tests.resources/pom.xml
runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
team/examples/org.eclipse.team.examples.filesystem/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From c139e613001895113af67ae95c32250af2e1fa4b Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 13 Jan 2025 11:44:38 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/resources/tests/org.eclipse.core.tests.resources.saveparticipant1/META-INF/MANIFEST.MF b/resources/tests/org.eclipse.core.tests.resources.saveparticipant1/META-INF/MANIFEST.MF
index 596965d6ae..c6dd4c3976 100644
--- a/resources/tests/org.eclipse.core.tests.resources.saveparticipant1/META-INF/MANIFEST.MF
+++ b/resources/tests/org.eclipse.core.tests.resources.saveparticipant1/META-INF/MANIFEST.MF
@@ -4,7 +4,7 @@ Automatic-Module-Name: org.eclipse.core.tests.resources.saveparticipant1
 Bundle-Name: Save Participant 1
 Bundle-Activator: org.eclipse.core.tests.resources.saveparticipant1.SaveParticipant1Plugin
 Bundle-SymbolicName: org.eclipse.core.tests.resources.saveparticipant1
-Bundle-Version: 3.6.100.qualifier
+Bundle-Version: 3.6.200.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.resources.saveparticipant1
 Require-Bundle: org.eclipse.core.resources,
diff --git a/resources/tests/org.eclipse.core.tests.resources.saveparticipant2/META-INF/MANIFEST.MF b/resources/tests/org.eclipse.core.tests.resources.saveparticipant2/META-INF/MANIFEST.MF
index 1887dfcc87..b9625ba4a7 100644
--- a/resources/tests/org.eclipse.core.tests.resources.saveparticipant2/META-INF/MANIFEST.MF
+++ b/resources/tests/org.eclipse.core.tests.resources.saveparticipant2/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Automatic-Module-Name: org.eclipse.core.tests.resources.saveparticipant2
 Bundle-Name: Save Participant 2
 Bundle-SymbolicName: org.eclipse.core.tests.resources.saveparticipant2
-Bundle-Version: 3.6.100.qualifier
+Bundle-Version: 3.6.200.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.resources.saveparticipant2
 Require-Bundle: org.eclipse.core.resources,
diff --git a/resources/tests/org.eclipse.core.tests.resources.saveparticipant3/META-INF/MANIFEST.MF b/resources/tests/org.eclipse.core.tests.resources.saveparticipant3/META-INF/MANIFEST.MF
index 23490922fa..0485ef00a8 100644
--- a/resources/tests/org.eclipse.core.tests.resources.saveparticipant3/META-INF/MANIFEST.MF
+++ b/resources/tests/org.eclipse.core.tests.resources.saveparticipant3/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Save Participant 3
 Bundle-SymbolicName: org.eclipse.core.tests.resources.saveparticipant3
 Automatic-Module-Name: org.eclipse.core.tests.resources.saveparticipant3
-Bundle-Version: 3.6.100.qualifier
+Bundle-Version: 3.6.200.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.resources.saveparticipant3
 Require-Bundle: org.eclipse.core.resources,
diff --git a/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF b/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
index cbb54734ff..9f542ab492 100644
--- a/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
+++ b/resources/tests/org.eclipse.core.tests.resources/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse Core Tests Resources
 Bundle-SymbolicName: org.eclipse.core.tests.resources; singleton:=true
-Bundle-Version: 3.11.700.qualifier
+Bundle-Version: 3.11.800.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.filesystem,
  org.eclipse.core.tests.internal.alias,
diff --git a/resources/tests/org.eclipse.core.tests.resources/pom.xml b/resources/tests/org.eclipse.core.tests.resources/pom.xml
index 44f9740e18..d5293064bf 100644
--- a/resources/tests/org.eclipse.core.tests.resources/pom.xml
+++ b/resources/tests/org.eclipse.core.tests.resources/pom.xml
@@ -18,7 +18,7 @@
     <version>4.35.0-SNAPSHOT</version>
   </parent>
   <artifactId>org.eclipse.core.tests.resources</artifactId>
-  <version>3.11.700-SNAPSHOT</version>
+  <version>3.11.800-SNAPSHOT</version>
   <packaging>eclipse-test-plugin</packaging>
 
   <properties>
diff --git a/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF b/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
index d70afdf6ca..960ca86689 100644
--- a/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
+++ b/runtime/tests/org.eclipse.core.tests.harness/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: Eclipse Core Tests Harness
 Bundle-SymbolicName: org.eclipse.core.tests.harness;singleton:=true
-Bundle-Version: 3.17.100.qualifier
+Bundle-Version: 3.17.200.qualifier
 Bundle-Vendor: Eclipse.org
 Export-Package: org.eclipse.core.tests.harness;version="2.0",
  org.eclipse.core.tests.harness.session,
diff --git a/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF b/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
index 37f9608e6f..6f5b1094e8 100644
--- a/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
+++ b/team/examples/org.eclipse.team.examples.filesystem/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.team.examples.filesystem; singleton:=true
-Bundle-Version: 3.7.500.qualifier
+Bundle-Version: 3.7.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.team.examples.filesystem,
diff --git a/team/examples/org.eclipse.team.examples.filesystem/pom.xml b/team/examples/org.eclipse.team.examples.filesystem/pom.xml
index 3319fc49b2..76adc3aafc 100644
--- a/team/examples/org.eclipse.team.examples.filesystem/pom.xml
+++ b/team/examples/org.eclipse.team.examples.filesystem/pom.xml
@@ -18,7 +18,7 @@
     <relativePath>../../</relativePath>
   </parent>
   <artifactId>org.eclipse.team.examples.filesystem</artifactId>
-  <version>3.7.500-SNAPSHOT</version>
+  <version>3.7.600-SNAPSHOT</version>
   <packaging>eclipse-plugin</packaging>
   <build>
   	<plugins>
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Test Results

 1 728 files   -  27   1 728 suites   - 27   1h 32m 38s ⏱️ + 6m 27s
 4 170 tests ±  0   4 147 ✅ ±  0   22 💤 ±0  1 ❌ ±0 
12 954 runs   - 153  12 789 ✅  - 153  164 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 6c5b4db. ± Comparison against base commit 3f7070e.

♻️ This comment has been updated with latest results.

@jukzi
Copy link
Contributor

jukzi commented Jan 13, 2025

I generally like usage of Files.*. One just has to be careful about the default charset used.

@akurtakov
Copy link
Member Author

That's the reason why I aim at tests firsts.

@akurtakov
Copy link
Member Author

Jenkins is fine.

@akurtakov akurtakov merged commit 023ee35 into eclipse-platform:master Jan 13, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants