Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dispose call for Color #1696

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Conversation

akurtakov
Copy link
Member

According to the Javadoc on Color:

  • Colors do not need to be disposed, however to maintain compatibility
  • with older code, disposing a Color is not an error.

akurtakov and others added 2 commits January 19, 2025 21:53
According to the Javadoc on Color:

 * Colors do not need to be disposed, however to maintain compatibility
 * with older code, disposing a Color is not an error.
@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From ffccb898266d7c143328fe045e98f3fcb5bb54af Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Sun, 19 Jan 2025 19:58:28 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
index f0230dc3c6..de5362b9c6 100644
--- a/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.debug.examples.ui/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.debug.examples.ui;singleton:=true
-Bundle-Version: 1.8.500.qualifier
+Bundle-Version: 1.8.600.qualifier
 Bundle-Activator: org.eclipse.debug.examples.ui.pda.DebugUIPlugin
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.core.resources,
diff --git a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
index 4f372665c1..f6aec99b11 100644
--- a/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
+++ b/debug/org.eclipse.unittest.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.unittest.ui
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.unittest.ui;singleton:=true
-Bundle-Version: 1.1.400.qualifier
+Bundle-Version: 1.1.500.qualifier
 Bundle-Activator: org.eclipse.unittest.internal.UnitTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.47.1

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

Test Results

 1 755 files  ±0   1 755 suites  ±0   1h 31m 15s ⏱️ + 6m 5s
 4 170 tests ±0   4 147 ✅ ±0   23 💤 ±0  0 ❌ ±0 
13 107 runs  ±0  12 940 ✅ ±0  167 💤 ±0  0 ❌ ±0 

Results for commit 329b9f2. ± Comparison against base commit 47ea4b0.

@akurtakov akurtakov merged commit 0dfe86c into eclipse-platform:master Jan 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants