Rework Kubernetes resource naming and set up common unit tests #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #324
Note: This will need a rebase if the formatting PR #325 is merged first. Otherwise, the touched Java files need to be formatted in the PR, too.
Rework the naming of Kubernetes resources for workspaces and sessions in the common package used by operator and service.
The goal is to make resource names more readable and contain useful information. Resource names now contain a prefix, optional identifier, user, app definition and the last segment of the source CRs (session, workspace, app definition) UID.
Also configure unit tests using JUnit 5 for the common maven module and add some tests for the new name generation.
Notes:
email
resp.proxy
to be as short and concise as possible.See an example of created resources for a user
bar
with app definitiontheia-cloud-demo
: