Only apply a better profile if allowed #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking for Tycho 5 only as it is probably a breaking change, so lets see what all fails now. |
laeubi
force-pushed
the
fixup_determination_of_profiles
branch
3 times, most recently
from
2b70930 to
0d5ceee
Compare
|
I think the message is quite expected here:
so we probably should update the tests here and then apply the change even to Tycho 4 |
laeubi
added
the
backport-to-tycho-4.0.x
laeubi
force-pushed
the
fixup_determination_of_profiles
branch
5 times, most recently
from
f18003a to
c282f3a
Compare
|
Update of the BREEs extracted here: this should then be rebased on the PR to provide the actual fix. |
Currently we have a lot of old integration tests that require different BREEs due to historical reasons even though we already depend on much newer dependencies. This update the BREE of all test that do not explicitly test a specific feature related to the BREE to Java 17 to reflect the things we actually use.
Currently a configured profile is unconditionally replaced by a better one of the current JVM, but this is wrong if not explicitly allowed by the configuration. This is now changed, to be only used if ignoring the BREE is actually enabled.
laeubi
force-pushed
the
fixup_determination_of_profiles
branch
from
c282f3a to
6a45b75
Compare
laeubi
removed
the
backport-to-tycho-4.0.x
|
This should be manually be packported to tycho 4.x as we need to add a special note to the release notes about this possibly braking behavior compared to previous version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a configured profile is unconditionally replaced by a better one of the current JVM, but this is wrong if not explicitly allowed by the configuration.
This is now changed, to be only used if ignoring the BREE is actually enabled.