Skip to content

Commit

Permalink
Remove un-necessary comments
Browse files Browse the repository at this point in the history
  • Loading branch information
vietj committed Oct 18, 2024
1 parent a866a07 commit 7af9155
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,6 @@ public void testHandleWSManually() throws Exception {

@Test
public void testSharedServersRoundRobin() throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);

int numServers = VertxOptions.DEFAULT_EVENT_LOOP_POOL_SIZE / 2- 1;
int numConnections = numServers * 100;

Expand Down
5 changes: 0 additions & 5 deletions vertx-core/src/test/java/io/vertx/tests/tls/HttpTLSTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -1552,7 +1552,6 @@ public void testHttpsProxy() throws Exception {
}

private void testProxy(ProxyType proxyType) throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);
startProxy(null, proxyType);
testTLS(Cert.NONE, Trust.SERVER_JKS, Cert.SERVER_JKS, Trust.NONE).useProxy(proxyType).pass();
assertNotNull("connection didn't access the proxy", proxy.getLastUri());
Expand All @@ -1568,7 +1567,6 @@ public void testHttpsProxyWithSNI() throws Exception {
}

private void testProxyWithSNI(ProxyType proxyType) throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);
startProxy(null, proxyType);
Certificate cert = testTLS(Cert.NONE, Trust.SNI_JKS_HOST2, Cert.SNI_JKS, Trust.NONE)
.serverSni()
Expand All @@ -1584,15 +1582,13 @@ private void testProxyWithSNI(ProxyType proxyType) throws Exception {
@Test
// Check that proxy auth fails if it is missing
public void testHttpsProxyAuthFail() throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);
startProxy("username", ProxyType.HTTP);
testTLS(Cert.NONE, Trust.SERVER_JKS, Cert.SERVER_JKS, Trust.NONE).useProxy(ProxyType.HTTP).fail();
}

@Test
// Access https server via connect proxy with proxy auth required
public void testHttpsProxyAuth() throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);
startProxy("username", ProxyType.HTTP);
testTLS(Cert.NONE, Trust.SERVER_JKS, Cert.SERVER_JKS, Trust.NONE).useProxy(ProxyType.HTTP).useProxyAuth().pass();
assertNotNull("connection didn't access the proxy", proxy.getLastUri());
Expand All @@ -1606,7 +1602,6 @@ public void testHttpsProxyAuth() throws Exception {
// the hostname may resolve at the proxy if that is accessing another DNS
// we simulate this by mapping the hostname to localhost:xxx in the test proxy code
public void testHttpsProxyUnknownHost() throws Exception {
// assumeTrue(TRANSPORT != Transport.IO_URING);
startProxy(null, ProxyType.HTTP);
proxy.setForceUri(DEFAULT_HTTPS_HOST_AND_PORT);
testTLS(Cert.NONE, Trust.SERVER_JKS, Cert.SERVER_JKS, Trust.NONE).useProxy(ProxyType.HTTP)
Expand Down

0 comments on commit 7af9155

Please sign in to comment.