Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scram-sha-256 out of the box #1481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

julianladisch
Copy link
Contributor

Remove <optional>true</optional> from com.ongres.scram:scram-client dependency in pom.xml.

Since PostgreSQL 14 the default value for password_encryption is scram-sha-256.

Explain the migration from Vert.x 4 to Vert.x 5 in index.adoc - the client has been changed from client to scram-client:
https://github.com/eclipse-vertx/vertx-sql-client/pull/1431/files

Fixes #944, #1059, #1189, #1249, #1266, #1398, #1466

Motivation:

The client fails with all default installations of PostgreSQL versions >= 14.

Conformance:

Remove `<optional>true</optional>` from com.ongres.scram:scram-client dependency.

Since PostgreSQL 14+ the default value for password_encryption is scram-sha-256.

Explain the migration from Vert.x 4 to Vert.x 5 in index.adoc - the client has been
changed from `client` to `scram-client`:
https://github.com/eclipse-vertx/vertx-sql-client/pull/1431/files

Fixes eclipse-vertx#944, eclipse-vertx#1059, eclipse-vertx#1189, eclipse-vertx#1249, eclipse-vertx#1266, eclipse-vertx#1398, eclipse-vertx#1466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should add SCRAM client to vertx-sql-client dependency list
1 participant