Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy creation of the list proxyInformation #3318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubenporras
Copy link
Contributor

By doing that, when resources already linked are loaded from storage, no memory needs to be allocated for the proxyInformation list.

@rubenporras
Copy link
Contributor Author

for #3317

Copy link

github-actions bot commented Jan 17, 2025

Test Results

  6 461 files  ±0    6 461 suites  ±0   3h 10m 48s ⏱️ - 20m 51s
 43 241 tests ±0   42 657 ✅ ±0    584 💤 ±0  0 ❌ ±0 
170 249 runs  +3  167 904 ✅ ±0  2 337 💤 ±0  8 ❌ +3 

Results for commit 3a5ec14. ± Comparison against base commit 07b7598.

♻️ This comment has been updated with latest results.

By doing that, when resources already linked are loaded from storage, no
memory needs to be allocated for the proxyInformation list.
@LorenzoBettini
Copy link
Contributor

@rubenporras compilation error.

@rubenporras
Copy link
Contributor Author

@rubenporras compilation error.

Sorry, I have not figured out yet what to do to make an Xtext workspace work without going through the steps in https://github.com/eclipse-xtext/xtext/blob/main/CONTRIBUTING.md#set-up-your-eclipse-workspace

Do you happen to know how to setup the workspace after manually cloning the repo? Do I need to trigger some maven configuration? I have M2E installed but nothing happens out of the box.

@LorenzoBettini
Copy link
Contributor

@rubenporras compilation error.

Sorry, I have not figured out yet what to do to make an Xtext workspace work without going through the steps in https://github.com/eclipse-xtext/xtext/blob/main/CONTRIBUTING.md#set-up-your-eclipse-workspace

Do you happen to know how to setup the workspace after manually cloning the repo? Do I need to trigger some maven configuration? I have M2E installed but nothing happens out of the box.

What's wrong with the Oomph setup we carefully baked with love? ;)
jokes aside, please use the Oomph setup; if you already cloned the repo, you can specify the path of the cloned repo during the setup.

@rubenporras
Copy link
Contributor Author

@rubenporras compilation error.

Sorry, I have not figured out yet what to do to make an Xtext workspace work without going through the steps in https://github.com/eclipse-xtext/xtext/blob/main/CONTRIBUTING.md#set-up-your-eclipse-workspace
Do you happen to know how to setup the workspace after manually cloning the repo? Do I need to trigger some maven configuration? I have M2E installed but nothing happens out of the box.

What's wrong with the Oomph setup we carefully baked with love? ;) jokes aside, please use the Oomph setup; if you already cloned the repo, you can specify the path of the cloned repo during the setup.

Thanks, that works. I have not realized I could point it to an already cloned repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants