Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] Notebook CodeActionKind Support #95

Closed
wants to merge 1 commit into from
Closed

Conversation

rschnekenbu
Copy link

What it does

Fix missing API CodeActionKind notebook made public on vscode 1.83.
The static kind is available for notebooks, which allows to activate an extension without troubles and to register notebook edit values.
As a remark, the preferences do not align on the current vscode versions for 'editor: Code Actions On Save' possible values. There are no more boolean, but enum (automatic / explicit / etc.).
As a second remark, the save Participant behavior is not yet supported, and the adaptations required for notebook saveParticipants are not yet available. So all adaptations made on vscode issue 192248 cannot be implemented.

Note: changelog will be pushed once PR is created against main repo.

Fixes eclipse-theia#13059

Contributed on behalf of ST Microelectronics

How to test

  1. Install the following extension on Theia master:
  1. Start browser theia

  2. On activation, the following error is shown:
    notebook-codeactionkind-before

  3. Switch to the branch and rebuild

  4. Starting with the extension, no more errors shall popup

  5. an action item shall come when in the cell of a notebook editor. I created a 'test.ipynb' file for that with dummy content. The action will add content to the cell when selected.

Follow-ups

  • Implement properly the saveParticipants and check the specific behavior for notebooks works as expected. see vscode issue for that.
  • The preference 'editor:Code Actions On Save' shall be updated as soon as the monaco version is uplifted

Review checklist

Reminder for reviewers

@rschnekenbu rschnekenbu requested a review from tsmaeder November 17, 2023 13:21
@tsmaeder
Copy link
Collaborator

What's with the failing license check?

@rschnekenbu
Copy link
Author

Good question! I will have a look because I don't see how a 2-liner can have impact on that. It seems also that licences were OK this morning with a PR on main repo.

@rschnekenbu rschnekenbu removed the request for review from tsmaeder November 17, 2023 13:59
Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
@rschnekenbu
Copy link
Author

Closing, replaced by similar PR on main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vscode] Support CodeActionKind notebook
2 participants