Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on python 3.9 QA and fix typing #104

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Turn on python 3.9 QA and fix typing #104

merged 2 commits into from
Jan 13, 2025

Conversation

gmertes
Copy link
Member

@gmertes gmertes commented Jan 13, 2025

  • Turn on python 3.9 in the QA version matrix
  • type | None is unsupported in python 3.9, replace it with Optional[type] or Union[type, type, None]

Other instances of | do work thanks to __future__.annotations , so I left those alone.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (90728d5) to head (b10dce8).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #104   +/-   ##
========================================
  Coverage    98.03%   98.03%           
========================================
  Files            3        3           
  Lines           51       51           
========================================
  Hits            50       50           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmertes gmertes changed the title Fix python 3.9 typing Turn on python 3.9 QA and fix typing Jan 13, 2025
@gmertes gmertes merged commit ff2bd59 into develop Jan 13, 2025
75 of 77 checks passed
@gmertes gmertes deleted the fix/tests branch January 13, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants