Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sweep Rules] Avoid using magic numbers or hardcoding values #1200

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Oct 25, 2023

PR Feedback: 👎

I created this PR to address this rule:

"Avoid using magic numbers or hardcoding values."

Description

This PR addresses the issue of avoiding magic numbers or hardcoding values in the project. The version number "3.23.0" of the "dls-icons-vue" package was hardcoded in several package.json files and the pnpm-lock.yaml file. To conform to the rule, the version numbers have been updated to use variables or constants instead.

Summary of Changes

  • Created a new JSON file named version.json in the packages directory to store the version number.
  • Added a script named update-version.js to read the version number from version.json and update the package.json files in the veui-theme-dls-icons, veui-theme-dls, and veui directories.
  • Modified the package.json file to include a new script named "update-version" to run the update-version.js script.

Please review and merge this PR to ensure compliance with the coding guidelines.

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Oct 25, 2023

Rollback Files For Sweep

  • Rollback changes to package.json

@sweep-ai sweep-ai bot added the Sweep label Oct 25, 2023
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
veui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2023 4:19am

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1200 (1e4b401) into main (711c431) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1200   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files         234      234           
  Lines       12213    12213           
  Branches     3623     3623           
=======================================
  Hits        10683    10683           
  Misses       1530     1530           
Files Coverage Δ
packages/veui/src/components/TagInput.vue 100.00% <ø> (ø)

@Justineo Justineo closed this Oct 25, 2023
@Justineo Justineo deleted the sweep/avoid-magic-numbers branch November 6, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant