Fix warnings under GCC #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes warnings under GCC, putting dependency headers under SYSTEM so that warnings are not surfaced for these, also adds configurable warning settings for EDGE specific sources. There was some mixed tabs/spaces that were also causing issues specifically with misleading conditionals, thus the whitespace fixes
I disabled these, though should circle back on them, and perhaps opt in for some dependencies:
-Wno-unused-parameter -Wno-missing-field-initializers -Wno-stringop-truncation -Wno-stringop-overflowThere are a few warnings left for void* deletes and switch fallthrus, which talked about in Discord. Overall not bad at all, and now can see legit things we should fix not masked with 1K+ lines of warning spam