Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/upgrade to 0.37.0 #12

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Feat/upgrade to 0.37.0 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed9243c
feat(upgrade): upgrade to version 0.37.0
smileisak Mar 4, 2024
114de8d
feat(upgrade): fix golangci
smileisak Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
env:
# Common versions
GO_VERSION: '1.19'
GOLANGCI_VERSION: 'v1.52.2'
GOLANGCI_VERSION: 'v1.56.2'
DOCKER_BUILDX_VERSION: 'v0.8.2'

# Common users. We can't run a step 'if secrets.XXX != ""' but we can run a
Expand Down
5 changes: 2 additions & 3 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ linters-settings:

dupl:
# tokens count to trigger issue, 150 by default
threshold: 100
threshold: 300

goconst:
# minimal length of string constant, 3 by default
Expand Down Expand Up @@ -96,7 +96,6 @@ linters:
- megacheck
- govet
- gocyclo
- interfacer
- goconst
- goimports
- gofmt # We enable this as well as goimports for its simplify mode.
Expand Down Expand Up @@ -182,4 +181,4 @@ issues:
max-same-issues: 0

service:
golangci-lint-version: 1.52.2
golangci-lint-version: 1.56.2
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ export TERRAFORM_VERSION ?= 1.2.1

export TERRAFORM_PROVIDER_SOURCE ?= ovh/ovh
export TERRAFORM_PROVIDER_REPO ?= https://github.com/ovh/terraform-provider-ovh
export TERRAFORM_PROVIDER_VERSION ?= 0.36.1
export TERRAFORM_PROVIDER_VERSION ?= 0.37.0
export TERRAFORM_PROVIDER_DOWNLOAD_NAME ?= terraform-provider-ovh
export TERRAFORM_PROVIDER_DOWNLOAD_URL_PREFIX ?= https://releases.hashicorp.com/$(TERRAFORM_PROVIDER_DOWNLOAD_NAME)/$(TERRAFORM_PROVIDER_VERSION)
export TERRAFORM_NATIVE_PROVIDER_BINARY ?= terraform-provider-ovh_v0.36.1
export TERRAFORM_NATIVE_PROVIDER_BINARY ?= terraform-provider-ovh_v0.37.0
export TERRAFORM_DOCS_PATH ?= website/docs


Expand Down Expand Up @@ -41,7 +41,7 @@ NPROCS ?= 1
GO_TEST_PARALLEL := $(shell echo $$(( $(NPROCS) / 2 )))

GO_REQUIRED_VERSION ?= 1.19
GOLANGCILINT_VERSION ?= 1.52.2
GOLANGCILINT_VERSION ?= 1.56.2
GO_STATIC_PACKAGES = $(GO_PROJECT)/cmd/provider $(GO_PROJECT)/cmd/generator
GO_LDFLAGS += -X $(GO_PROJECT)/internal/version.Version=$(VERSION)
GO_SUBDIRS += cmd internal apis
Expand Down
Loading
Loading