Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: a reading window acquires the lock when multiple windows are opened with the same publication ID #2706

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

panaC
Copy link
Member

@panaC panaC commented Dec 11, 2024

The lock is acquired by the reader window if :

  • The same publication is not already open and this is the first reading window with this publication.
  • An another reading window has the lock with this publication but this reading window is closing by the user.

@panaC panaC self-assigned this Dec 11, 2024
@panaC
Copy link
Member Author

panaC commented Dec 17, 2024

@danielweck I'm merging this PR feel free to comment it in #develop branch. I'm need this for #2704

@panaC panaC merged commit d25a395 into develop Dec 17, 2024
8 checks passed
@panaC panaC deleted the reader-lock branch December 17, 2024 13:42
@danielweck
Copy link
Member

That's fine :)
I did read the code diff but without utilisation context the logic is a bit abstract in my mind.
Purely from a technical perspective, I am glad to see that the module-level unbound cache now has a "delete" function ;)

panaC added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants