Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not reset peer state on new established connection #16

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jan 25, 2024

libp2p may establish multiple connections at the same time to a peer and we shouldn't reset the state.

@oblique oblique requested review from fl0rek and zvolin January 25, 2024 14:38
libp2p may establish multiple connections at the same time
to a peer and we shouldn't reset the state.
@oblique oblique force-pushed the fix/multiple-connections branch from 8932861 to 405464f Compare January 25, 2024 14:40
src/client.rs Outdated Show resolved Hide resolved
Co-authored-by: Maciej Zwoliński <[email protected]>
@oblique oblique requested a review from zvolin January 25, 2024 16:41
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@fl0rek fl0rek merged commit e737dbe into eigerco:main Jan 26, 2024
4 checks passed
This was referenced Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants