feat: transform in common js

[Shunjun]

if a commonjs module imported by es module.the global name will be transformed. but a commonjs module imported by another commonjs module it will not be transformed.

in this case if bar is global.

- node_modules:
  - bar:
    - index.js: | 
        module.exports = "BAR";
  - foo:
    - index.js: | 
        const bar = require("bar"); // <- this will not be replaced, and alse will be packaged
        console.log('foo');
        module.exports = (val) => console.log(val || bar);
- entry.js: |
    import log from "foo";
    import bar from "bar" // <- this will be replaced
    log(bar);

I think this is not right. so i transformed it after @rollup/plugin-commonjs.
And i added a new config to control this feature, default is closed.

[eight04]

It seems that commonjs transforms the absolute require bar into its full path path/to/bar/index.js and write it into the source (commonjs-proxy). Therefore external-globals doesn't know that full path is an external module.

I think the correct solution is: external-globals should register a resolveId handler which runs before commonjs. When finding an identifier matching the global variable map, mark it as external so commonjs won't try to expand the id into its full path.

external-globals should not transform commonjs modules.

[Shunjun]

I think you're right. I'll fix it later

[eight04]

LGTM

[eight04]

What does globals do?

[Shunjun]

Because you imported it in eslint.config.mjs. transitive dependencies is not work in pnpm.
I've deleted it.

[eight04]

We can remove this option.

[Shunjun]

removed

[eight04]

Same as above.

[Shunjun]

removed

[Shunjun]

I found another case that behaviour is not as before.

Suppose "bar" is the external module.

// foo.js
export * from "bar"

// index.js
import {a} from "foo.js"

console.log(a);

• Before
  Rollup will check the bar module, and write into index. Although external-globals didn't do anything with "export * ".

I think it's also problematic that 'a' in global bar maybe not as same as in local bar

// output
const a = 1;
console.log(a);

• Now
  The bar has been external. so rollup doesn't check this module.

// output
import {a} from "bar"
console.log(a);

now the bar can not be resolved.

I'm not sure that's a problem, maybe user should not export * from an external global module
But to resolve this problem I think we need transform code again in renderChunk.

[eight04]

export * from "bar"

It's a known issue that external-globals doesn't work with export all syntax:
#25

transform code again in renderChunk

This will only work if output.format = "es".