Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the model based on Olive Camera lenses and setup. #60

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

agalbachicar
Copy link
Member

@agalbachicar agalbachicar commented Sep 23, 2024

🎉 New feature

Closes #33

Summary

Introduces a handful of changes that make the scene alike the real setup.

  • Changes the lens configuration.
  • Changes the scale of the objects.
  • Changes the pose of the camera.
  • Changes the QoS setting of the camera based on experimentation.
  • Changes the default settings for RQt

Test it

Should be able to build and run a system and observe the scene configuration is similar to the observed data in the rosbag.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@agalbachicar agalbachicar force-pushed the agalbachicar/33_calibrate_camera_and_setup branch from 2154071 to 5a80a89 Compare September 26, 2024 17:32
@agalbachicar agalbachicar changed the title [WIP] Updates the model based on Olive Camera lenses and setup. Updates the model based on Olive Camera lenses and setup. Sep 26, 2024
Copy link
Collaborator

@ndelima-ekumen ndelima-ekumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (there's a training log in the training_ws folder that got in, I think accidentally)

Signed-off-by: Agustin Alba Chicar <[email protected]>
@agalbachicar agalbachicar merged commit 4ee5382 into main Sep 27, 2024
1 check passed
@agalbachicar agalbachicar deleted the agalbachicar/33_calibrate_camera_and_setup branch September 27, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calibrate camera and setup model with real camera samples
2 participants